docs(admin): improve nginx config php location block structure and clarity#14172
Merged
docs(admin): improve nginx config php location block structure and clarity#14172
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
CarlSchwan,
MichaIng,
SystemKeeper and
susnux
MichaIng
reviewed
Mar 27, 2026
…gi_split_path_info result Co-authored-by: MichaIng <micha@dietpi.com> Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
MichaIng
approved these changes
Mar 27, 2026
Member
MichaIng
left a comment
MichaIng
left a comment
There was a problem hiding this comment.
LGTM. Explains much better the purpose of each directive, and helps to understand the general structure of typical PHP handler and rewrite blocks in Nginx 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Improve the comments and formatting of the PHP block (
location ~ \.php(?:$|/) {...}) in both nginx sample configuration files to make them clearer and more maintainable. Re-ordered the regex in therewritemerely for logical clarity, but no functional changes.Changes:
rewriteregex ordering to be slightly more logically grouped and, in turn, make easier to document/follow (core entry points / OCS endpoints / update/updater endpoints / app exceptions)🖼️ Screenshots
root installation:
subdirectory installation:
